Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed kubernetes provider in kubernetesIngress provider #5068

Merged
merged 2 commits into from
Jul 8, 2019

Conversation

jbdoumenjou
Copy link
Member

What does this PR do?

Renamed kubernetes provider in kubernetesIngress provider.

Motivation

Be clearer and homogeneous to avoid any confusion with the KubernetesCRD provider.

More

  • Added/updated tests
  • Added/updated documentation

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@ldez ldez force-pushed the feature/rename-k8s-ingress branch from b71e520 to be06be4 Compare July 8, 2019 19:24
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 8ab33db into traefik:v2.0 Jul 8, 2019
v2 automation moved this from To review to Done Jul 8, 2019
@jbdoumenjou jbdoumenjou deleted the feature/rename-k8s-ingress branch November 15, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants