Deal with multiple errors and their criticality #5070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpl
added
status/2-needs-review
area/api
kind/enhancement
ldez
force-pushed
the
slice-errors
branch
3 times, most recently
from
353adcc
to
d176fef
Compare
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
During the configuration of a router/service, several things can go wrong due to an improper configuration event. So far, for each router/service, we were not handling the fact that several errors can occur for the same entity, i.e. the last error would overwrite all previous errors. And that last error would be the only one showing up through the API handler.
In addition, some of the errors would be critical (i.e. no router would actually be created), while others would not be (the router is created, but with a default differing from what the user specified in the conf), and we were not distinguishing between these two cases.
Therefore, this PR:
Motivation
To better deal with configuration errors.
More
Added/updated documentationAdditional Notes
Co-authored-by: Julien Salleyron julien.salleyron@gmail.com