Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tracing documentation #5102

Merged
merged 1 commit into from Jul 16, 2019
Merged

Improve tracing documentation #5102

merged 1 commit into from Jul 16, 2019

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Jul 15, 2019

What does this PR do?

This PR adds YAML part for tracing documentation

Motivation

yaml

More

  • Added/updated tests
  • Added/updated documentation

@mmatur mmatur added this to the 2.0 milestone Jul 15, 2019
@mmatur mmatur added this to To review in v2 via automation Jul 15, 2019
@ldez ldez changed the title Feature improve tracing documentation Improve tracing documentation Jul 15, 2019
dtomcej
dtomcej approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

ldez
ldez approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the feature/improve-traecing-doc branch from 22c83e9 to 7e032db Compare July 16, 2019 07:42
@traefiker traefiker merged commit 889b38f into traefik:v2.0 Jul 16, 2019
v2 automation moved this from To review to Done Jul 16, 2019
@mmatur mmatur deleted the feature/improve-traecing-doc branch July 19, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/middleware/tracing kind/enhancement a new or improved feature. size/L
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmatur @juliens @ldez @dtomcej @traefiker