Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certificate resolvers. #5116

Merged
merged 5 commits into from Jul 19, 2019
Merged

Certificate resolvers. #5116

merged 5 commits into from Jul 19, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Jul 18, 2019

What does this PR do?

  • Dynamic wildcard
  • Challenge by domain(s) / multiple challenges
  • DNS provider by domain(s) / multiple DNS providers
  • Multiple certificates providers (acme, ...)

Motivation

Closes #4872

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: Julien Salleyron julien.salleyron@gmail.com
Co-authored-by: Jean-Baptiste Doumenjou jb.doumenjou@gmail.com

@ldez ldez added this to the 2.0 milestone Jul 18, 2019
@ldez ldez added this to To review in v2 via automation Jul 18, 2019
@ldez ldez force-pushed the feature/refacto-acme branch 3 times, most recently from dcaf2db to 1913396 Compare July 18, 2019 12:49
juliens
juliens approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpl
mpl reviewed Jul 18, 2019
View reviewed changes
cmd/traefik/traefik.go Outdated Show resolved Hide resolved
mpl
mpl reviewed Jul 18, 2019
View reviewed changes
cmd/traefik/traefik.go Outdated Show resolved Hide resolved
jbdoumenjou
jbdoumenjou requested changes Jul 18, 2019
View reviewed changes
docs/content/https/acme.md Outdated Show resolved Hide resolved
docs/content/user-guides/crd-acme/03-deployments.yml Outdated Show resolved Hide resolved
jbdoumenjou
jbdoumenjou approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SantoDE
SantoDE approved these changes Jul 19, 2019
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. AWESOME job 👏

mpl
mpl reviewed Jul 19, 2019
View reviewed changes
pkg/config/static/static_config.go Show resolved Hide resolved
pkg/config/static/static_config.go Outdated Show resolved Hide resolved
pkg/provider/acme/local_store.go Outdated Show resolved Hide resolved
pkg/provider/acme/local_store.go Show resolved Hide resolved
pkg/provider/acme/local_store.go Show resolved Hide resolved
pkg/provider/acme/local_store.go Outdated Show resolved Hide resolved
pkg/provider/acme/store.go Outdated Show resolved Hide resolved
pkg/server/router/route_appender_factory.go Show resolved Hide resolved
pkg/server/router/tcp/router.go Show resolved Hide resolved
pkg/tls/tlsmanager.go Show resolved Hide resolved
ldez and others added 5 commits July 19, 2019 09:34
@ldez @traefiker
feat: certificate resolvers.
017ea00
@ldez @mpl
@jbdoumenjou @traefiker
Apply suggestions from code review
aafa924 
Co-Authored-By: mpl <mathieu.lonjaret@gmail.com>
Co-Authored-By: Jean-Baptiste Doumenjou <jb.doumenjou@gmail.com>
@ldez @traefiker
review: fix.
a45cb89
@ldez @traefiker
review: fix.
0d013a6
@ldez @traefiker
review: fix.
bb6f9cd
@traefiker traefiker merged commit f75f73f into traefik:v2.0 Jul 19, 2019
v2 automation moved this from To review to Done Jul 19, 2019
@traefiker traefiker mentioned this pull request Jul 19, 2019
Closed
@EugenMayer
Copy link
Contributor

Wow, thanks for bringing that one in for 2.0 ... What a crazy packed release it will be!

@ldez ldez deleted the feature/refacto-acme branch July 19, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpl mpl mpl left review comments

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@SantoDE SantoDE SantoDE approved these changes

Assignees
No one assigned
Labels
area/acme kind/enhancement a new or improved feature. size/L
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ldez @EugenMayer @juliens @mpl @jbdoumenjou @SantoDE @traefiker