Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TLS configuration from directory. #5118

Merged
merged 1 commit into from Jul 18, 2019
Merged

fix: TLS configuration from directory. #5118

merged 1 commit into from Jul 18, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Jul 18, 2019 •
edited

What does this PR do?

fix: TLS configuration from directory.

Motivation

Related to:

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Jul 18, 2019
@traefiker traefiker added this to the 2.0 milestone Jul 18, 2019
@ldez ldez requested review from jbdoumenjou, juliens and mpl July 18, 2019 11:44
jbdoumenjou
jbdoumenjou approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SantoDE
SantoDE approved these changes Jul 18, 2019
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dduportal dduportal mentioned this pull request Jul 18, 2019
Closed
2 tasks
juliens
juliens approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 4dc4480 into traefik:v2.0 Jul 18, 2019
v2 automation moved this from To review to Done Jul 18, 2019
@ldez ldez deleted the fix/file-directory branch July 18, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@SantoDE SantoDE SantoDE approved these changes

@mpl mpl Awaiting requested review from mpl

Assignees
No one assigned
Labels
area/provider/file kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @jbdoumenjou @SantoDE @traefiker