Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix acme example #5130

Merged
merged 1 commit into from Jul 19, 2019
Merged

Fix acme example #5130

merged 1 commit into from Jul 19, 2019

Conversation

jamct
Copy link
Contributor

@jamct jamct commented Jul 19, 2019 •
edited

What does this PR do?

Fixes a wrong header in tabbed view. Second Tab is for YAML-file, not TOML

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@traefiker traefiker added this to the 2.0 milestone Jul 19, 2019
@dduportal
Copy link
Contributor

dduportal commented Jul 19, 2019 •
edited

Hi @jamct , can you fil your PR to describe the problem you're solving with this PR please?

ldez
ldez approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title Fixed header for tab 2 (YAML, not TOML) Fixed acme example Jul 19, 2019
@ldez ldez changed the title Fixed acme example Fix acme example Jul 19, 2019
@ldez ldez added the kind/bug/fix a bug fix label Jul 19, 2019
juliens
juliens approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dduportal
dduportal approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 📖 thanks!

@traefiker traefiker merged commit 3ef2971 into traefik:v2.0 Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mpl mpl mpl approved these changes

@dduportal dduportal dduportal approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/acme area/documentation kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jamct @dduportal @juliens @mpl @ldez @traefiker