Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for CLI #5131

Merged
merged 1 commit into from Aug 1, 2019
Merged

Add example for CLI #5131

merged 1 commit into from Aug 1, 2019

Conversation

alvarezbruned
Copy link

@alvarezbruned alvarezbruned commented Jul 19, 2019

There are few examples for CLI, and I see necessary CLI example to have everything in the docker-compose manifest;
in a single file instead of in a manifest and in a TOML file

What does this PR do?

Motivation

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alvarezbruned,

thanks a lot for your contribution!

WDYT about getting that in sync with the v2? @ldez

@dduportal
Copy link
Contributor

Hi @SantoDE , let's focus this PR on v1.7, as v2.0already have the CLI example now :)

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 📖

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in that case 👼

There are few examples for CLI, and I see necessary CLI example to have everything in the docker-compose manifest; 
in a single file instead of in a manifest and in a TOML file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants