Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use components to split Home concerns #5136

Merged
merged 3 commits into from Jul 22, 2019
Merged

Use components to split Home concerns #5136

merged 3 commits into from Jul 22, 2019

Conversation

Slashgear
Copy link
Contributor

What does this PR do?

  • Use bulma hero for WIP message
  • Use box instead of panels
  • Create Tile component wrap bulma component for Features
  • Create EntityStateDoughnut to move Chart logical in another component to avoid duplication and for readability.

Motivation

Now the new webui has been bootstrapped, this need some code cleanup

@traefiker traefiker added this to the 2.0 milestone Jul 20, 2019
@ldez ldez added this to To review in v2 via automation Jul 20, 2019
ldez
ldez approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

mmatur
mmatur approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks 👏

jbdoumenjou
jbdoumenjou approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 7c852fb into traefik:v2.0 Jul 22, 2019
v2 automation moved this from To review to Done Jul 22, 2019
@ldez ldez changed the title refactor(webui): use components to split Home concerns Use components to split Home concerns Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/webui kind/enhancement a new or improved feature. size/M
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Slashgear @jbdoumenjou @mmatur @ldez @traefiker