Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc and version in navbar #5137

Merged
merged 4 commits into from Aug 12, 2019
Merged

Add doc and version in navbar #5137

merged 4 commits into from Aug 12, 2019

Conversation

Slashgear
Copy link
Contributor

What does this PR do?

  • ✨ Add Version in Navbar
  • ✨ Add Documentation (based on version) link in Navbar

Question How can I map version api to doc api ?

Motivation

  • Helping User find Documentation directly in the Navbar is a sweet feature

@traefiker traefiker added this to the 2.0 milestone Jul 20, 2019
@Slashgear Slashgear changed the title Webui show version feat(webui): add doc and version in navbar Jul 20, 2019
@ldez ldez added this to To review in v2 via automation Jul 20, 2019
ldez
ldez requested changes Jul 22, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there seems to be a problem

TypeError: "this.version.Version.match(...) is null"
    parsedVersion App.vue:60
    VueJS 3
    documentationUrl App.vue:63
    VueJS 3
    n App.vue:1
    VueJS 7
        _render
        r
        get
        run
        Kn
        ft
        ut
vue.runtime.esm.js:1888
    VueJS 10

@Slashgear
Copy link
Contributor Author

Oops @ldez will fix that soon 🤕

@ldez
Copy link
Member

ldez commented Aug 4, 2019

@Slashgear friendly ping 😉

@Slashgear
Copy link
Contributor Author

In your case, what is the version JSON object from the version API ? :)

@ldez
Copy link
Member

ldez commented Aug 5, 2019 •
edited 

{
  "Version": "dev",
  "Codename": "cheddar"
}

@Slashgear
Copy link
Contributor Author

Is this ok for you now ?

ldez
ldez approved these changes Aug 11, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpl
mpl approved these changes Aug 12, 2019
View reviewed changes
Copy link
Collaborator

@mpl mpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but I did not see anything crazy.

@traefiker traefiker merged commit 6be390c into traefik:v2.0 Aug 12, 2019
v2 automation moved this from To review to Done Aug 12, 2019
@ldez ldez changed the title feat(webui): add doc and version in navbar Add doc and version in navbar Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mpl mpl mpl approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/webui kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Slashgear @ldez @juliens @mpl @dduportal @traefiker