Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lego #5166

Merged
merged 5 commits into from Aug 5, 2019
Merged

Update lego #5166

merged 5 commits into from Aug 5, 2019

Conversation

dabeck
Copy link

@dabeck dabeck commented Jul 30, 2019 •
edited by ldez

What does this PR do?

Updates acme-lego to 2.7.2.
Fixes #5165

Motivation

Issue #5165

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

dduportal
dduportal reviewed Jul 30, 2019
View reviewed changes
Gopkg.toml Outdated Show resolved Hide resolved
@dduportal

This comment has been minimized.

Sign in to view
@dabeck dabeck changed the base branch from master to v1.7 July 30, 2019 09:22
@dabeck dabeck changed the base branch from v1.7 to master July 30, 2019 09:22
@dabeck dabeck requested review from a team as code owners July 30, 2019 11:27
@dabeck dabeck changed the base branch from master to v1.7 July 30, 2019 11:30
dduportal
dduportal reviewed Jul 30, 2019
View reviewed changes
Gopkg.toml Show resolved Hide resolved
@mmatur mmatur requested a review from ldez July 30, 2019 15:25
@mmatur mmatur removed request for a team July 30, 2019 15:26
@mmatur
Copy link
Member

mmatur commented Jul 30, 2019

Thanks for your PR @dabeck

I would like to have the review of @ldez

@ldez ldez changed the title Update lego to 2.7.1 Update lego Aug 5, 2019
@ldez ldez removed the bot/no-merge label Aug 5, 2019
@ldez ldez added this to To review in v2 via automation Aug 5, 2019
@ldez ldez removed this from To review in v2 Aug 5, 2019
@ldez ldez added this to the 1.7 milestone Aug 5, 2019
ldez
ldez approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

mmatur
mmatur approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@ldez ldez removed the bot/no-merge label Aug 5, 2019
@traefiker traefiker merged commit 73e0561 into traefik:v1.7 Aug 5, 2019
@traefiker traefiker mentioned this pull request Aug 5, 2019
Closed
2 tasks
@dabeck dabeck deleted the update-lego branch August 6, 2019 08:30
@27Bslash6 27Bslash6 mentioned this pull request Aug 16, 2019
Merged
3 tasks
@drzraf

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal left review comments

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/M
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dabeck @dduportal @mmatur @drzraf @ldez @dtomcej @traefiker