Kubernetes support for Auth.HeaderField #5235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template modified to support ingress.kubernetes.io/auth-header-field
ldez
added
area/authentication
area/provider/k8s/ingress
kind/bug/fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template modified to support ingress.kubernetes.io/auth-header-field
What does this PR do?
Change to the kubernetes template to take auth-header-field into account.
Motivation
A kubernetes ingress with authentication always sends a header
X-WebAuth-Userwith the username to the backend. The documentation states, that the header name can be changed through the annoationingress.kubernetes.io/auth-header-field. This annotation is currently read from the kubernetes api but ignored when building the frontend definition.More
Additional Notes
The default behaviour of the code will change. The documentation does not exactly describe if that header field will be set without an annotation.