New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WeightedRoundRobin load balancer #5237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliens
added
kind/enhancement
a new or improved feature.
status/2-needs-review
area/server
labels
Aug 21, 2019
juliens
changed the title
WeightedRoundRobin load balancer
[breaking] WeightedRoundRobin load balancer
Aug 22, 2019
mpl
requested changes
Aug 23, 2019
mpl
approved these changes
Aug 23, 2019
ldez
approved these changes
Aug 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ldez
changed the title
[breaking] WeightedRoundRobin load balancer
WeightedRoundRobin load balancer
Aug 25, 2019
mmatur
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: mpl <mathieu.lonjaret@gmail.com>
This was referenced Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a new load balancer to make weighted round-robin load balancing.
Weighted RoundRobin balanced on services and not on servers.
Motivation
Be able to do weighted round-robin load balancing (like canary).
More
Additional Notes
Breaking changes
To be homogeneous with WRR, we renamed stickyness on server loadBalancer to sticky.
Co-authored-by: Ludovic Fernandez ldez@users.noreply.github.com