Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Access Logs Documentation page #5238

Merged
merged 2 commits into from Sep 11, 2019
Merged

Improve Access Logs Documentation page #5238

merged 2 commits into from Sep 11, 2019

Conversation

dduportal
Copy link
Contributor

Signed-off-by: dduportal 1522731+dduportal@users.noreply.github.com

What does this PR do?

This PR improves the documentation page for the configuration of Access Logs.

Motivation

More

  • [ ] Added/updated tests
  • Added/updated documentation

Additional Notes

This content is for v1.7 branch, but it should be reusable after the next merge back to the v2.0.

docs/configuration/logs.md Outdated Show resolved Hide resolved
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. great stuff :)

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

dduportal and others added 2 commits September 11, 2019 16:10
Signed-off-by: dduportal <1522731+dduportal@users.noreply.github.com>
Co-Authored-By: Jean-Baptiste Doumenjou <jb.doumenjou@gmail.com>
@traefiker traefiker merged commit 2d37f08 into traefik:v1.7 Sep 11, 2019
@dduportal dduportal deleted the docs/access-logs branch September 13, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants