Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: CRD user guide #5244

Merged
merged 1 commit into from Aug 23, 2019
Merged

Fix: CRD user guide #5244

merged 1 commit into from Aug 23, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Aug 23, 2019

What does this PR do?

--certificatesresolvers.default.acme.entrypoint=websecure

is not a valid option.

Motivation

Fixes #5243

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Aug 23, 2019
@traefiker traefiker added this to the 2.0 milestone Aug 23, 2019
dtomcej
dtomcej approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

nmengin
nmengin approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📖

juliens
juliens approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dduportal
dduportal approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 0fbd87c into traefik:v2.0 Aug 23, 2019
v2 automation moved this from To review to Done Aug 23, 2019
@traefiker traefiker mentioned this pull request Aug 23, 2019
Closed
2 tasks
@ldez ldez deleted the fix/crd-user-guide branch August 25, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@dduportal dduportal dduportal approved these changes

@nmengin nmengin nmengin approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/acme area/documentation area/provider/k8s/crd kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ldez @juliens @dduportal @nmengin @dtomcej @traefiker