Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recovered panic when websocket is mirrored #5255

Merged
merged 1 commit into from Aug 29, 2019

Conversation

juliens
Copy link
Member

@juliens juliens commented Aug 27, 2019

What does this PR do?

blackholeResponseWriter now implements http.Hijacker and http.Flusher interface.

Motivation

Fix a recovered panic when websocket is mirrored.

More

  • Added/updated tests

Additional Notes

When websocket is mirrored, we mirror the upgrade request but not the websocket messages after that.

@juliens juliens changed the base branch from master to v2.0 August 27, 2019 10:04
@ldez ldez added this to the 2.0 milestone Aug 27, 2019
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants