Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest provider icon in the webui #5261

Merged
merged 1 commit into from Aug 28, 2019
Merged

Rest provider icon in the webui #5261

merged 1 commit into from Aug 28, 2019

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Aug 28, 2019

What does this PR do?

This PR fix the rest provider icon in the webui.

Before:
image

After:
image

How to test it?:

rm -rf static && make generate-webui && go generate && go run ./cmd/traefik/traefik.go --api --providers.docker --providers.rest --entryPoints.http.address=:4342

@mmatur mmatur added this to the 2.0 milestone Aug 28, 2019
@mmatur mmatur added this to To review in v2 via automation Aug 28, 2019
ldez
ldez approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge and removed status/2-needs-review labels Aug 28, 2019
@ldez ldez changed the title This PR fix the rest provider icon in the webui Rest provider icon in the webui Aug 28, 2019
@traefiker traefiker merged commit 72e67bf into traefik:v2.0 Aug 28, 2019
v2 automation moved this from To review to Done Aug 28, 2019
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Aug 28, 2019
@mmatur mmatur deleted the fix/rest-icon branch September 3, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/webui kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmatur @ldez @traefiker