Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stripPrefixRegex documentation. #5273

Merged
merged 2 commits into from Sep 2, 2019
Merged

fix: stripPrefixRegex documentation. #5273

merged 2 commits into from Sep 2, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Aug 31, 2019

What does this PR do?

fix: stripPrefixRegex documentation.

Motivation

Have a good documentation.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to the 1.7 milestone Aug 31, 2019
@ldez ldez added this to To review in v2 via automation Aug 31, 2019
@ldez ldez modified the milestones: 1.7, 2.0 Aug 31, 2019
dtomcej
dtomcej approved these changes Aug 31, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

mmatur
mmatur approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 1755420 into traefik:v2.0 Sep 2, 2019
v2 automation moved this from To review to Done Sep 2, 2019
@ldez ldez deleted the fix/doc-stripprefixregex branch September 4, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/middleware kind/bug/fix a bug fix size/M
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @dtomcej @traefiker