New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more pages in the WebUI #5278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
contributor/waiting-for-corrections
kind/enhancement
a new or improved feature.
status/1-needs-design-review
and removed
status/0-needs-triage
labels
Sep 1, 2019
ldez
force-pushed
the
feat/webui-pages
branch
3 times, most recently
from
September 6, 2019 15:22
dcc20f5
to
a0545cd
Compare
- add HTTP Service Type LB servers (base page) - add HTTP Services - add HTTP Middleware - add TCP Routers - add TCP Services
…Path, redirectScheme, redirectRegex
ldez
force-pushed
the
feat/webui-pages
branch
from
September 10, 2019 11:27
315ed91
to
b8dc977
Compare
ldez
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jbdoumenjou
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mmatur
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add pages:
Motivation
Have a beautiful UI
More
Added/updated tests