Update Zipkin OpenTracing driver to latest 0.4.3 release #5283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the Zipkin dependency to use the latest Zipkin Go OpenTracing Bridge which builds on the native Zipkin Go tracer instead of the now deprecated zipkin-go-opentracing implementation.
Motivation
Zipkin has moved away from the old V1 data model to the new V2 data model allowing for improved efficiency, faster encoding and smaller transmit payloads. Up to release 0.4.0 the zipkin-go-opentracing package held its own internal implementation which was purely V1 based. The latest release of zipkin-go-opentracing uses the native Zipkin Go tracer which uses the V2 datamodel and provides the bridge to the OpenTracing API.
The change from v0.3.5 to v0.4.3 holds a breaking change in the bootstrap code of the tracer. This PR fixes that by bootstrapping the native Zipkin Go tracer and wrapping it with the OpenTracing Bridge.
More
Additional Notes
This PR unlocks the ability to add more configuration options for Zipkin to Traefik in a later stage. It is possible to select different styles of samplers as well as adding additional reporting transports (kafka, protobuf over json, grpc).
Fixes #5260