error pages: do not buffer response when it's not an error #5285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the error pages middleware, so that it does not buffer responses anymore.
As it was, the error pages middleware was using a response writer, to intercept the response coming from the backend, analyse the code in the response, so that it would know the error pages handler should take over and be in charge of writing the error response.
The problem is, it was keeping the response's body in memory so that, when the backend does not reply with an error, we could reconstruct the original response and forward it to the client. Which means, with large enough responses, it would result in large memory footprints.
This PR adds a new response writer (codeCatcher), that analyses the code in the response as soon as possible, without buffering the response's body. Then, if the code is among the one's we're handling, it drops the contents of the response, because the actual newResponseRecorder is going to reissue the request to the backend anyway, and record the response again. Otherwise, it forwards the response directly to the original client, without any buffering having occurred.
Motivation
Fixing #4474
More
[ ] Added/updated tests[ ] Added/updated documentationAdditional Notes
Fixes #4474