Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some documentation issues #5286

Merged
merged 15 commits into from Sep 3, 2019
Merged

Fix some documentation issues #5286

merged 15 commits into from Sep 3, 2019

Conversation

jbdoumenjou
Copy link
Member

What does this PR do?

Fix some documentation issues like:

  • ambiguous elements
  • typo
  • bad examples
  • wrong information

Motivation

Have a better documentation.

More

  • Added/updated tests
  • Added/updated documentation

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/content/middlewares/headers.md Outdated Show resolved Hide resolved
docs/content/middlewares/headers.md Outdated Show resolved Hide resolved
docs/content/middlewares/headers.md Outdated Show resolved Hide resolved
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 261e7c1 into traefik:v2.0 Sep 3, 2019
v2 automation moved this from To review to Done Sep 3, 2019
@jbdoumenjou jbdoumenjou deleted the fix/doc branch September 4, 2019 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants