Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stripPrefix and stripPrefixRegex. #5291

Merged
merged 5 commits into from Sep 3, 2019
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 3, 2019

What does this PR do?

Don't return a 404 when the path is not stripped.

Motivation

To be able to use stripPrefix and stripPrefixRegex.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Sep 3, 2019
@traefiker traefiker added this to the 2.0 milestone Sep 3, 2019
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-Authored-By: mpl <mathieu.lonjaret@gmail.com>
@traefiker traefiker merged commit f843f26 into traefik:v2.0 Sep 3, 2019
v2 automation moved this from To review to Done Sep 3, 2019
@ldez ldez deleted the fix/strip-prefix branch September 3, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants