Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider in middleware chain #5334

Merged
merged 2 commits into from Sep 10, 2019
Merged

Conversation

juliens
Copy link
Member

@juliens juliens commented Sep 9, 2019

What does this PR do?

This PR adds the provider in middleware chain.

Motivation

We want to have only middleware ref with provider in the API.

More

  • Added/updated tests

@traefiker traefiker added this to the 2.0 milestone Sep 9, 2019
@ldez ldez added this to To review in v2 via automation Sep 9, 2019
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit 34be181 into traefik:v2.0 Sep 10, 2019
v2 automation moved this from To review to Done Sep 10, 2019
@ldez ldez deleted the api-provider branch September 10, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants