Added configurable prefix for statsd metrics collection #5336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/middleware/metrics
kind/enhancement
|
Any news on this? this is a Roadblock for us to upgrade to 2.0, as we currently run a custom 1.7 with this feature. |
schulterklopfer
force-pushed
the
feature/traefik_prefix
branch
from
ca0bd72
to
254e348
Compare
ldez
changed the title
ldez
requested changes
Oct 25, 2019
There was a problem hiding this comment.
Thanks,
Could you add the documentation:
- run
go generateto generate CLI and env vars doc - add the option in
docs/content/observability/metrics/statsd.md - add the option in
docs/content/reference/static-configuration/file.toml - add the option in
docs/content/reference/static-configuration/file.yaml
|
Do you need anything additional from me? I think I addressed the change requests in my latest commits. :) |
|
Hi @schulterklopfer, Thanks for you contribution, unfortunately the bot is not able to merge the PR because, it is not allowed to rebase your PR on the master branch Could you please rebase your PR on master, or give the right to maintainers to update your PR |
removed space Co-Authored-By: Ludovic Fernandez <ldez@users.noreply.github.com>
schulterklopfer
force-pushed
the
feature/traefik_prefix
branch
from
7b4c1de
to
0edaa02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We installed multiple instances of traefik for request seperation. To monitor our setup in a better way, we needed configurable statsd prefixes, so the metrics won't end up in one big bucket :)