Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: services configuration documentation. #5359

Merged
merged 2 commits into from Sep 12, 2019
Merged

fix: services configuration documentation. #5359

merged 2 commits into from Sep 12, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 11, 2019 •
edited

What does this PR do?

fix: services configuration documentation.

Motivation

Have a good documentation.

Fixes #5352

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Sep 11, 2019
@traefiker traefiker added this to the 2.0 milestone Sep 11, 2019
dtomcej
dtomcej approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

juliens
juliens approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 7357d5e into traefik:v2.0 Sep 12, 2019
v2 automation moved this from To review to Done Sep 12, 2019
@traefiker traefiker mentioned this pull request Sep 12, 2019
Closed
2 tasks
@ldez ldez deleted the fix/doc-services branch September 12, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @jbdoumenjou @dtomcej @traefiker