Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable collect data by default. #5393

Merged
merged 1 commit into from Sep 16, 2019
Merged

Disable collect data by default. #5393

merged 1 commit into from Sep 16, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 16, 2019

What does this PR do?

Disable collect data by default.

Motivation

Before the GA, leaving this option unset will not prevent Traefik from running but will generate an error log indicating that it enables data collection by default.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Sep 16, 2019
@ldez ldez added this to To review in v2 via automation Sep 16, 2019
@traefiker traefiker added this to the 2.0 milestone Sep 16, 2019
geraldcroes
geraldcroes approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 47a9b08 into traefik:v2.0 Sep 16, 2019
v2 automation moved this from To review to Done Sep 16, 2019
@ldez ldez deleted the fix/disable-collect-as-default branch September 16, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@geraldcroes geraldcroes geraldcroes approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ldez @juliens @geraldcroes @mmatur @nmengin @traefiker