Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix indentation for tab on migration guide #5423

Merged
merged 1 commit into from Sep 19, 2019
Merged

fix indentation for tab on migration guide #5423

merged 1 commit into from Sep 19, 2019

Conversation

viceice
Copy link
Contributor

@viceice viceice commented Sep 19, 2019

What does this PR do?

Fixes a wrong indentation for tab tracing -> info v2 -> yaml.

Motivation

Migrate to v2. 馃槈

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

nope 馃槄

@viceice
fix indentation for tab on migration guide
9a2fbd3 
The is a wrong indentation, so the tab for `tracing` -> `info v2` ->  `yaml` is missing.
@traefiker traefiker added this to the 2.0 milestone Sep 19, 2019
@viceice
Copy link
Contributor Author

viceice commented Sep 19, 2019

old: https://docs.traefik.io/v2.0/migration/v1-to-v2/#tracing
new: https://deploy-preview-5423--traefik-doc.netlify.com/migration/v1-to-v2/#tracing

dduportal
dduportal approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks a lot!

LGTM 馃摉 馃憤

jbdoumenjou
jbdoumenjou approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit e8fc16d into traefik:v2.0 Sep 19, 2019
@viceice viceice deleted the patch-1 branch September 19, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@dduportal dduportal dduportal approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@viceice @jbdoumenjou @dduportal @ldez @traefiker