Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag names don't need a consistent case. #5438

Merged
merged 1 commit into from Sep 20, 2019
Merged

Flag names don't need a consistent case. #5438

merged 1 commit into from Sep 20, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 20, 2019

What does this PR do?

Before this PR, the flags are case sensitive but the flags require a consistent case.

By example:

the following flags doesn't have a consistent case on certificatesresolvers:

--certificatesresolvers.default.acme.email=my@email.com
--certificatesResolvers.default.acme.storage=/my-acme.json
--certifiCatesresolvers.default.acme.httpchallenge.entrypoint=http

=> only one flag is read (not expected)

With this PR, the flags names don't need to have a consistent case.

Motivation

Fixes #5360

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Sep 20, 2019
@traefiker traefiker added this to the 2.0 milestone Sep 20, 2019
@ldez ldez mentioned this pull request Sep 20, 2019
Closed
2 tasks
jbdoumenjou
jbdoumenjou approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dduportal
dduportal approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

mmatur
mmatur approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 9005731 into traefik:v2.0 Sep 20, 2019
v2 automation moved this from To review to Done Sep 20, 2019
@ldez ldez deleted the fix/case-consistency branch September 20, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@dduportal dduportal dduportal approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/cli kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @jbdoumenjou @dduportal @mmatur @traefiker