Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve routing documentation #5450

Merged
merged 22 commits into from Sep 23, 2019
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 21, 2019

What does this PR do?

  • review routing sections and providers sections.
  • review getting started.
  • review entry point section.
  • quick review of operation.
  • add info on the static configuration migration.
  • fix some typos

Motivation

Have a better documentation.

More

  • Added/updated tests
  • Added/updated documentation

docs/content/contributing/data-collection.md Outdated Show resolved Hide resolved
docs/content/contributing/data-collection.md Outdated Show resolved Hide resolved
docs/content/middlewares/circuitbreaker.md Outdated Show resolved Hide resolved
docs/content/middlewares/circuitbreaker.md Outdated Show resolved Hide resolved
@traefik traefik deleted a comment from mpl Sep 23, 2019
@traefik traefik deleted a comment from mpl Sep 23, 2019
Co-Authored-By: mpl <mathieu.lonjaret@gmail.com>
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first batch of review. This is really a great work that helps to improve and clarify the doc for newcomers 👍

docs/content/getting-started/configuration-overview.md Outdated Show resolved Hide resolved
docs/content/getting-started/install-traefik.md Outdated Show resolved Hide resolved
docs/content/https/acme.md Show resolved Hide resolved
docs/content/middlewares/buffering.md Outdated Show resolved Hide resolved
docs/content/routing/entrypoints.md Show resolved Hide resolved
docs/content/routing/entrypoints.md Show resolved Hide resolved
docs/content/routing/entrypoints.md Show resolved Hide resolved
docs/content/routing/entrypoints.md Show resolved Hide resolved
docs/content/routing/entrypoints.md Show resolved Hide resolved
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez and others added 3 commits September 23, 2019 12:32
Co-Authored-By: Damien Duportal <damien.duportal@gmail.com>
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@traefiker traefiker merged commit bfde17b into traefik:v2.0 Sep 23, 2019
v2 automation moved this from To review to Done Sep 23, 2019
@ldez ldez deleted the improve/doc-routing branch September 23, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants