Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in TOML for HTTP to HTTPS redirection #5452

Merged
merged 1 commit into from Sep 23, 2019
Merged

fix: typo in TOML for HTTP to HTTPS redirection #5452

merged 1 commit into from Sep 23, 2019

Conversation

krerkkiat
Copy link
Contributor

What does this PR do?

Fix a typo in example TOML file for HTTP to HTTPS redirection

Motivation

I ran into problem following the example.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@traefiker traefiker added this to the 2.0 milestone Sep 22, 2019
ldez
ldez approved these changes Sep 22, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ldez ldez added this to To review in v2 via automation Sep 22, 2019
dduportal
dduportal approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks!

@traefiker traefiker merged commit 855468e into traefik:v2.0 Sep 23, 2019
v2 automation moved this from To review to Done Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpl mpl mpl approved these changes

@dduportal dduportal dduportal approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@krerkkiat @mpl @dduportal @ldez @traefiker