Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker service name. #5491

Merged
merged 3 commits into from Sep 26, 2019
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 25, 2019

What does this PR do?

fix: docker service name.

Motivation

In some case the docker service name can start with /.

Fixes #5489

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Sep 25, 2019
@traefiker traefiker added this to the 2.0 milestone Sep 25, 2019
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants