Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify automatic service creation/assignment with labels #5493

Merged
merged 3 commits into from Sep 26, 2019
Merged

clarify automatic service creation/assignment with labels #5493

merged 3 commits into from Sep 26, 2019

Conversation

mpl
Copy link
Collaborator

@mpl mpl commented Sep 25, 2019 •
edited by ldez

What does this PR do?

This PR specifies in the doc some particular cases of automatic service creation and/or assignment to a router, with providers making use of labels.

Motivation

To improve the doc.

Close #5455

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@mpl mpl added this to the 2.0 milestone Sep 25, 2019
@mpl mpl added this to To review in v2 via automation Sep 25, 2019
ldez
ldez approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

geraldcroes
geraldcroes requested changes Sep 26, 2019
View reviewed changes
docs/content/routing/providers/marathon.md Outdated Show resolved Hide resolved
docs/content/routing/providers/marathon.md Outdated Show resolved Hide resolved
docs/content/routing/providers/service-by-label.md Outdated Show resolved Hide resolved
docs/content/routing/providers/service-by-label.md Outdated Show resolved Hide resolved
docs/content/routing/providers/service-by-label.md Outdated Show resolved Hide resolved
docs/content/routing/providers/service-by-label.md Show resolved Hide resolved
docs/content/routing/providers/service-by-label.md Outdated Show resolved Hide resolved
docs/content/routing/providers/service-by-label.md Outdated Show resolved Hide resolved
geraldcroes
geraldcroes approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit c6e783e into traefik:v2.0 Sep 26, 2019
v2 automation moved this from To review to Done Sep 26, 2019
@traefiker traefiker mentioned this pull request Sep 26, 2019
Closed
2 tasks
@mpl mpl deleted the autoservice branch April 13, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geraldcroes geraldcroes geraldcroes approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/docker area/provider/marathon area/provider/rancher kind/enhancement a new or improved feature. size/M
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mpl @geraldcroes @ldez @dtomcej @traefiker