Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix doc about file.filename #5494

Merged
merged 2 commits into from Sep 26, 2019
Merged

fix doc about file.filename #5494

merged 2 commits into from Sep 26, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 25, 2019

What does this PR do?

Add the right doc about file.filename

Motivation

Have a better documentation

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Sep 25, 2019
@traefiker traefiker added this to the 2.0 milestone Sep 25, 2019
dtomcej
dtomcej reviewed Sep 25, 2019
View reviewed changes
docs/content/reference/static-configuration/cli-ref.md Outdated Show resolved Hide resolved
docs/content/reference/static-configuration/env-ref.md Outdated Show resolved Hide resolved
pkg/provider/file/file.go Outdated Show resolved Hide resolved
dduportal
dduportal approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

dtomcej
dtomcej approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

geraldcroes
geraldcroes approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez and others added 2 commits September 26, 2019 07:10
@ldez @traefiker
doc: fix doc about file.filename
f0264fb
@ldez @dtomcej @traefiker
Apply suggestions from code review
ab8e447 
Co-Authored-By: Daniel Tomcej <daniel.tomcej@gmail.com>
@traefiker traefiker merged commit ea78808 into traefik:v2.0 Sep 26, 2019
v2 automation moved this from To review to Done Sep 26, 2019
@ldez ldez deleted the fix/file-filename-doc branch September 26, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geraldcroes geraldcroes geraldcroes approved these changes

@dduportal dduportal dduportal approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/file kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @geraldcroes @dduportal @dtomcej @traefiker