Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the pass host header section to the services documentation #5500

Merged
merged 4 commits into from Sep 30, 2019

Conversation

jbdoumenjou
Copy link
Member

What does this PR do?

Add the pass host header section to the services documentation with a file provider example.

Motivation

Have a better documentation.

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 2.0 milestone Sep 26, 2019
@jbdoumenjou jbdoumenjou added this to To review in v2 via automation Sep 26, 2019
docs/content/routing/services/index.md Outdated Show resolved Hide resolved
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@traefiker traefiker merged commit 211fa18 into traefik:v2.0 Sep 30, 2019
v2 automation moved this from To review to Done Sep 30, 2019
@jbdoumenjou jbdoumenjou deleted the doc/passHostHeader branch November 15, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants