Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State clearly, that they are mutual exclusive #5527

Merged
merged 2 commits into from Oct 7, 2019

Conversation

lnxbil
Copy link
Contributor

@lnxbil lnxbil commented Sep 27, 2019

What does this PR do?

Enhance the documentation of the file provider and state that the directory and filename are mutual exclusive.

Motivation

Ran into a problem, asked in the forum and was asked to create a PR.

More

  • Added/updated documentation

@ldez ldez force-pushed the provider-file-doc-improvement branch from 35ebd87 to 5b8b92c Compare September 27, 2019 14:44
@ldez ldez changed the base branch from master to v2.0 September 27, 2019 14:44
@ldez ldez added this to the 2.0 milestone Sep 27, 2019
@ldez ldez added this to To review in v2 via automation Sep 27, 2019
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the provider-file-doc-improvement branch from 0c50405 to 00b25a4 Compare October 7, 2019 12:42
@traefiker traefiker merged commit b2b142a into traefik:v2.0 Oct 7, 2019
v2 automation moved this from To review to Done Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants