Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$ needs escaping in docker-compose.yml #5528

Merged
merged 1 commit into from Sep 30, 2019

Conversation

lnxbil
Copy link
Contributor

@lnxbil lnxbil commented Sep 27, 2019

What does this PR do?

As with other parts of the documentation, the $ must be escaped for docker-compose.yml integration and these are the ones I just found.

Motivation

Just found them and wanted to fix.

More

  • Added/updated documentation

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added this to To review in v2 via automation Sep 27, 2019
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As with other parts of the documentation, the `$` must be escaped and
these are the ones I just found.
@traefiker traefiker force-pushed the docker-compose-escape-characters branch from 212f504 to 0bee406 Compare September 30, 2019 16:28
@traefiker traefiker merged commit 0082fe8 into traefik:v2.0 Sep 30, 2019
v2 automation moved this from To review to Done Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants