Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix influxDB and statsD case in configuration page. #5531

Merged
merged 2 commits into from Sep 30, 2019
Merged

doc: fix influxDB and statsD case in configuration page. #5531

merged 2 commits into from Sep 30, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 28, 2019

What does this PR do?

  • doc: fix influxDB case in configuration page.
  • doc: fix statsD case in configuration page.

Motivation

Have a better documentation.

Fixes #5530

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Sep 28, 2019
@traefiker traefiker added this to the 2.0 milestone Sep 28, 2019
mmatur
mmatur approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dduportal
dduportal approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 30ad00f into traefik:v2.0 Sep 30, 2019
v2 automation moved this from To review to Done Sep 30, 2019
@traefiker traefiker mentioned this pull request Sep 30, 2019
Closed
2 tasks
@ldez ldez deleted the fix/doc-influxDB branch September 30, 2019 13:06
@killua99
Copy link

How this MR will fix the API callback? I was talking about the API callback the user is missing or at least that's the error I get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@dduportal dduportal dduportal approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/documentation area/middleware/metrics kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ldez @killua99 @jbdoumenjou @dduportal @mmatur @traefiker