Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml domains example #5569

Merged
merged 2 commits into from Oct 7, 2019
Merged

Fix yaml domains example #5569

merged 2 commits into from Oct 7, 2019

Conversation

SuperSandro2000
Copy link
Contributor

What does this PR do?

Fix the example

Motivation

I was frustrated why the example did not work.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ldez ldez added this to To review in v2 via automation Oct 5, 2019
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 9691085 into traefik:v2.0 Oct 7, 2019
v2 automation moved this from To review to Done Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants