Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in log #5590

Merged
merged 1 commit into from Oct 7, 2019
Merged

Fix typo in log #5590

merged 1 commit into from Oct 7, 2019

Conversation

XciD
Copy link
Contributor

@XciD XciD commented Oct 7, 2019

What does this PR do?

Motivation

fixed a typo

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@ldez ldez changed the base branch from master to v2.0 October 7, 2019 07:58
@ldez ldez added this to the 2.0 milestone Oct 7, 2019
ldez
ldez approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ldez ldez added this to To review in v2 via automation Oct 7, 2019
jbdoumenjou
jbdoumenjou approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez
Copy link
Member

ldez commented Oct 7, 2019 •
edited

@XciD you don't need to merge or rebase, our bot manage that part.

@XciD
Copy link
Contributor Author

XciD commented Oct 7, 2019

@XciD you don't merge to merge or rebase, our bot manage that part.

Ok, sorry :)

@traefiker traefiker merged commit a2cd69b into traefik:v2.0 Oct 7, 2019
v2 automation moved this from To review to Done Oct 7, 2019
@XciD XciD deleted the fix/typo branch October 7, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/crd area/provider/k8s kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@XciD @ldez @jbdoumenjou @mmatur @traefiker