Improve ciphersuite examples #5594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the TLS_RSA_WITH_AES_256_GCM_SHA384 cipher that causes the B rating from https://www.ssllabs.com/ssltest/ This cipher is considered weak and including it in documentation will lead people to get a B by default. Adding the ciphers that are not considered weak will result in an A rating out of the box.
Removed the TLS_RSA_WITH_AES_256_GCM_SHA384 cipher that causes the B rating from https://www.ssllabs.com/ssltest/ This cipher is considered weak and including it in documentation will lead people to get a B by default. Adding the ciphers that are not considered weak will result in an A rating out of the box.
ldez
added
area/documentation
status/2-needs-review
and removed
status/0-needs-triage
labels
2 tasks
ldez
changed the title
mmatur
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removed the TLS_RSA_WITH_AES_256_GCM_SHA384 cipher that causes the B rating from https://www.ssllabs.com/ssltest/
This cipher is considered weak and including it will result in a B rating by default.
Adding the ciphers that are not considered weak will result in an A rating out of the box.
Removes the TLS_RSA_WITH_AES_256_GCM_SHA384 cipher that is considered weak.
Motivation
After the removal of this cipher the site security rating raises from a B to an A.
More
Additional Notes
It'd be useful, in the future, to provide a configuration that gives an A+ rating out of the box.