Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apiVersion in documentation descriptor #5605

Merged
merged 1 commit into from Oct 9, 2019
Merged

Update apiVersion in documentation descriptor #5605

merged 1 commit into from Oct 9, 2019

Conversation

pyaillet
Copy link
Contributor

@pyaillet pyaillet commented Oct 9, 2019

What does this PR do?

Update apiVersion in documentation descriptor

Motivation

The old extensions/v1beta1 Deployment API is deprecated.

More

  • Updated documentation

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks a lot (btw there might other like this change sneaking around in the doc ;) )

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added this to To review in v2 via automation Oct 9, 2019
@ldez ldez added the kind/enhancement a new or improved feature. label Oct 9, 2019
@ldez ldez changed the title fix api version in descriptor Update apiVersion in documentation descriptor Oct 9, 2019
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit b552efe into traefik:v2.0 Oct 9, 2019
v2 automation moved this from To review to Done Oct 9, 2019
@pyaillet
Copy link
Contributor Author

pyaillet commented Oct 9, 2019

@dduportal I greped through the directory and didn't find other references to extensions/v1beta1 for Deployments.

However there are many references to extensions/v1beta1 Ingress which should be updated for Kubernetes 1.20, but as the networking.k8s.io/v1beta1 Ingress is only served since 1.14 I think this could be done later.

@pyaillet pyaillet deleted the fix/update_apiversion branch October 9, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants