Normalize service and router names for ingress. #5623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/2-needs-review
area/provider/k8s/ingress
kind/bug/fix
2 tasks
mpl
reviewed
Oct 11, 2019
| @@ -335,10 +335,7 @@ func (p *Provider) loadConfigurationFromIngresses(ctx context.Context, client Cl | |||
| rules = append(rules, "PathPrefix(`"+p.Path+"`)") | |||
| } | |||
|
|
|||
| routerKey := strings.Replace(rule.Host, ".", "-", -1) + strings.Replace(p.Path, "/", "-", 1) | |||
There was a problem hiding this comment.
the second strings.Replace was doing the replacement only on the first occurrence found, so is it safe to replace it with a call to provider.Normalize? is that what we want for sure?
There was a problem hiding this comment.
yes it's the expected behavior.
mpl
approved these changes
Oct 14, 2019
traefiker
force-pushed
the
fix/service-name-ingress
branch
from
cab53d5
to
9e741e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Normalize service and router names for ingress.
Motivation
remove
/from namesFixes #5611
More
Added/updated testsAdded/updated documentation