Add support for MaxVersion in tls.Options #5650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/tls
kind/enhancement
ldez
requested changes
Oct 25, 2019
ldez
added
contributor/waiting-for-documentation
and removed
contributor/waiting-for-corrections
labels
docs/content/https/tls.md docs/content/reference/dynamic-configuration/file.toml docs/content/reference/dynamic-configuration/file.yaml
|
I think a note which discourages this setting should be added to not disable TLS1.3. The right approach would be to encourage the clients to update. |
jbdoumenjou
requested changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for maxVersion to the tls.Options
Motivation
Some Chrome clients still have issues with negotiations associated with TLS Version 13.
Having the ability to set Maximum can avoid this problem.
More
Additional Notes
This is my first contribution to traefik, so let me know if I've done this correctly.
see #5649