Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add stacktrace when recover. #5654

Merged
merged 1 commit into from Oct 18, 2019
Merged

fix: add stacktrace when recover. #5654

merged 1 commit into from Oct 18, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Oct 15, 2019

What does this PR do?

Adds stacktrace when recover.

Motivation

Be able to debug panic easily

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Oct 15, 2019
@traefiker traefiker added this to the 2.0 milestone Oct 15, 2019
juliens
juliens approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

jbdoumenjou
jbdoumenjou approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 3884a68 into traefik:v2.0 Oct 18, 2019
v2 automation moved this from To review to Done Oct 18, 2019
@ldez ldez deleted the fix/recovery branch October 18, 2019 11:29
This was referenced Oct 21, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/middleware kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @jbdoumenjou @dtomcej @traefiker