Let instana/go-sensor handle default agent host #5658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
added
kind/enhancement
ldez
added
kind/bug/fix
ldez
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
as agentDefaultHost is localhost by default, it's a non breaking change.
https://github.com/instana/go-sensor/blob/37630c4806bc847402a7c168c159e8344ceace4b/fsm.go#L82-L92
https://github.com/instana/go-sensor/blob/56457d4adf449c1e5b723badaa0c3054c63316af/agent.go#L19
Passing an empty string as default host allows instana/go-sensor to look up INSTANA_HOST_AGENT env var. See https://github.com/instana/go-sensor/blob/master/fsm.go#L82-L92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Passing an empty string as default host allows instana/go-sensor to look up INSTANA_HOST_AGENT env var.
See https://github.com/instana/go-sensor/blob/master/fsm.go#L82-L92
Motivation
In a kubernetes env it enables the possibility to give to traefik the ip of the host which should have a local instana agent.
More
Additional Notes