Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify unit of duration field in access log #5664

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Clarify unit of duration field in access log #5664

merged 2 commits into from
Oct 16, 2019

Conversation

Sarke
Copy link
Contributor

@Sarke Sarke commented Oct 16, 2019 •
edited by ldez

What does this PR do?

Clarifies the unit of duration field in access logs.

Fixes #3493.

See #3493 (comment)

Motivation

I too needed clarification and did not find it in the docs.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

No.

@traefiker traefiker added this to the 2.0 milestone Oct 16, 2019
@ldez ldez changed the title Fix #3493, documentation: clarify unit of duration field in access log Clarify unit of duration field in access log Oct 16, 2019
@ldez ldez added this to To review in v2 via automation Oct 16, 2019
ldez
ldez approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

mmatur
mmatur approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dduportal
dduportal approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 👍

@traefiker traefiker merged commit 02bdc1d into traefik:v2.0 Oct 16, 2019
v2 automation moved this from To review to Done Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation area/logs kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Sarke @dduportal @mmatur @ldez @traefiker