Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect DNS reference #5666

Merged
merged 1 commit into from Oct 16, 2019
Merged

fix incorrect DNS reference #5666

merged 1 commit into from Oct 16, 2019

Conversation

oskapt
Copy link
Contributor

@oskapt oskapt commented Oct 16, 2019

The LetsEncrypt staging infrastructure, and certificates in general, have nothing to do with root DNS servers.

What does this PR do?

Fixes a documentation error.

Motivation

I was reading the docs and noticed the error.

@traefiker traefiker added this to the 2.0 milestone Oct 16, 2019
@ldez ldez added area/documentation kind/enhancement a new or improved feature. and removed status/0-needs-triage labels Oct 16, 2019
@ldez ldez added this to To review in v2 via automation Oct 16, 2019
ldez
ldez approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

dtomcej
dtomcej approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

dduportal
dduportal approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot 👍

@oskapt @traefiker
fix incorrect DNS reference
f40014b 
The LetsEncrypt staging infrastructure, and certificates in general, have nothing to do with root DNS servers.
@traefiker traefiker merged commit 554e3e9 into traefik:v2.0 Oct 16, 2019
v2 automation moved this from To review to Done Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/acme area/documentation kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oskapt @dduportal @ldez @dtomcej @traefiker