Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo for stripPrefix in tab File (YAML) #5694

Merged
merged 1 commit into from Oct 20, 2019
Merged

fix typo for stripPrefix in tab File (YAML) #5694

merged 1 commit into from Oct 20, 2019

Conversation

nalakawula
Copy link
Contributor

What does this PR do?

This PR is to fix typo in Strip Path Prefix When Forwarding to Backend.

Motivation

I just want to give little contribution for traefik v2 documentation.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@traefiker traefiker added this to the 2.0 milestone Oct 20, 2019
ldez
ldez approved these changes Oct 20, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ldez ldez added this to To review in v2 via automation Oct 20, 2019
dduportal
dduportal approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

dtomcej
dtomcej approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit 2042fdf into traefik:v2.0 Oct 20, 2019
v2 automation moved this from To review to Done Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nalakawula @dduportal @ldez @dtomcej @traefiker