Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proxy protocol logger to DEBUG level #5712

Merged
merged 2 commits into from Oct 24, 2019
Merged

Set proxy protocol logger to DEBUG level #5712

merged 2 commits into from Oct 24, 2019

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Oct 23, 2019

What does this PR do?

This PR force the debug log to DEBUG for proxyprotocol

Motivation

Fixes #5697

More

  • Added/updated tests
  • Added/updated documentation

@mmatur mmatur added this to the 2.0 milestone Oct 23, 2019
dtomcej
dtomcej approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@ldez ldez added this to To review in v2 via automation Oct 23, 2019
ldez
ldez approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title Override proxy protocol logger Set proxy protocol logger to DEBUG level Oct 23, 2019
dduportal
dduportal approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@traefiker traefiker merged commit a6cdd70 into traefik:v2.0 Oct 24, 2019
v2 automation moved this from To review to Done Oct 24, 2019
@traefiker traefiker mentioned this pull request Oct 24, 2019
Closed
@mmatur mmatur deleted the fix/log-proxyprotocol branch October 25, 2019 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/logs kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmatur @dduportal @ldez @dtomcej @traefiker