Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debug for log about skipping addition of cert #5726

Closed
wants to merge 2 commits into from

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Oct 25, 2019

What does this PR do?

This entry can flood the logs if a cert is duplicated like wildcard certs can be.

Motivation

Backport #5641 in v1.7 tree.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
@sylr
Copy link
Contributor Author

sylr commented Oct 25, 2019

FYI, this is what happened when we deployed the v2.0 patched version:

Search___Splunk_7_0_11_1

@ldez
Copy link
Member

ldez commented Oct 25, 2019

Hello,

I recommend to use the level WARN (the default level) instead of INFO in your configuration.

@sylr
Copy link
Contributor Author

sylr commented Oct 25, 2019

Hi

I recommend to use the level WARN (the default level) instead of INFO in your configuration.

But if I do this I would lose access logs which use the INFO level, wouldn't I ?

@ldez
Copy link
Member

ldez commented Oct 25, 2019

The log level is for Traefik log.

Some logs in Traefik log can be interpreted as "access log" but I recommend to not use it for that.

The access logs don't have a level.

@ldez
Copy link
Member

ldez commented Oct 28, 2019

As much as this change made sense in the v2 because of the management of the TLS on the routers, as much on the v1 that does not seem to me relevant.

So we will declined.

Thanks anyway.

@ldez ldez closed this Oct 28, 2019
@sylr sylr deleted the fix-logs-flood branch April 11, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants